Skip to content

feat: Implement BackendUtilization LB OutOfBand reporting - #9593

Open
jukie wants to merge 3 commits into
envoyproxy:mainfrom
jukie:impl-backendutilization-oob
Open

feat: Implement BackendUtilization LB OutOfBand reporting#9593
jukie wants to merge 3 commits into
envoyproxy:mainfrom
jukie:impl-backendutilization-oob

Conversation

@jukie

@jukie jukie commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Implementation for #9400 plus docs and e2e

Which issue(s) this PR fixes:

Fixes #9401

@netlify

netlify Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 046e8d1
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a6ae05cffa2c8000847b15a
😎 Deploy Preview https://deploy-preview-9593--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

jukie
jukie commented Jul 28, 2026
View reviewed changes
Comment thread go.mod Outdated
Comment on lines +15 to +18
github.com/envoyproxy/go-control-plane v0.14.1-0.20260728043526-94c89e8656f4
github.com/envoyproxy/go-control-plane/contrib v1.36.1-0.20260728043526-94c89e8656f4
github.com/envoyproxy/go-control-plane/envoy v1.37.1-0.20260728043526-94c89e8656f4
github.com/envoyproxy/go-control-plane/ratelimit v0.1.1-0.20260728043526-94c89e8656f4

@jukie jukie Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump was needed to include the OrcaOobReportingConfig API field

@jukie
jukie force-pushed the impl-backendutilization-oob branch 2 times, most recently from 19677c5 to d90b0c8 Compare July 29, 2026 21:43
@jukie

jukie commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: d90b0c865d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov

codecov Bot commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.68%. Comparing base (f63003f) to head (637a0f6).

Files with missing lines Patch % Lines
internal/gatewayapi/clustersettings.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9593      +/-   ##
==========================================
- Coverage   75.70%   75.68%   -0.03%     
==========================================
  Files         254      254              
  Lines       42110    42131      +21     
==========================================
+ Hits        31880    31885       +5     
- Misses       8085     8096      +11     
- Partials     2145     2150       +5

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jukie
Implement BackendUtilization OutOfBand ORCA reporting
17af668 
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie
jukie force-pushed the impl-backendutilization-oob branch from d90b0c8 to 17af668 Compare July 29, 2026 23:14
@jukie jukie changed the title Impl backendutilization oob feat: Implement BackendUtilization OutOfBand ORCA reporting Jul 29, 2026
@jukie jukie changed the title feat: Implement BackendUtilization OutOfBand ORCA reporting feat: Implement BackendUtilization LB OutOfBand reporting Jul 29, 2026
jukie
jukie commented Jul 29, 2026
View reviewed changes
Comment thread api/v1alpha1/loadbalancer_types.go
// +kubebuilder:validation:Maximum=65535
// +optional
// +notImplementedHide
Port *int32 `json:"port,omitempty"`

@jukie jukie Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @zhaohuabing #9400 (comment)

@zhaohuabing I ended up reverting this back to *int32. We only use it in one other place currently vs int32 for 8 other port fields and it breaks the kubebuilder bounds setup.

Let's continue here on whether to use PortNumber instead.

@jukie
jukie marked this pull request as ready for review July 29, 2026 23:19
@jukie
jukie requested a review from a team as a code owner July 29, 2026 23:19
@jukie
jukie requested review from a team and zhaohuabing July 30, 2026 04:02
@arkodg arkodg added this to the v1.9.0-rc.1 Release milestone Jul 30, 2026
@arkodg
arkodg requested review from a team July 30, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkodg arkodg arkodg approved these changes
@zhaohuabing zhaohuabing Awaiting requested review from zhaohuabing

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.9.0-rc.1 Release

Development

Successfully merging this pull request may close these issues.

Support ORCA Out Of Band Reporting on BackendUtilization LoadBalancer

2 participants

@jukie @arkodg